create workflows for deploying front + back end #472
Conversation
mattdelsordo
force-pushed
the
mattdelsordo/deploy-workflow
branch
from
8933d1a to
da3a712
Compare
|
Forgot about the environment variables - will be adding that in. |
mattdelsordo
force-pushed
the
mattdelsordo/deploy-workflow
branch
from
da3a712 to
a08028e
Compare
There was a problem hiding this comment.
Unfortunately I had to revert this change here because it borked the tests. The problem solved still exists so we're going to have to address it anyway: #469
| context: frontend/front | ||
| port: 8080 | ||
| secrets: | ||
| build-args: | |
There was a problem hiding this comment.
Not 100% positive all of the "normal" secrets are going to get passed like I expect...
|
@mattdelsordo I see secrets at |
|
@mattdelsordo Can you remove the now to be unused bits in https://github.com/codeforboston/urban-league-heat-pump-accelerator/blob/main/.github/workflows/test.yml so that we aren't building images for AWS anymore as a part of the workflow. |
mattdelsordo
force-pushed
the
mattdelsordo/deploy-workflow
branch
from
d4193a9 to
2d1b463
Compare
|
@mzagaja would you be able to fix the back-end security check? |
|
@mzagaja does this look good to merge? |
|
@mattdelsordo I was hoping to dig into this and test it today but the MassOpenCloud server space is having an issue. Hopefully it resolves soon. Meanwhile I will review from a code perspective. |
.github/workflows/deploy.yml
Outdated
|
|
||
| env: | ||
| REACT_APP_PUBLIC_SURVEY_ENABLED: 'false' | ||
| REACT_APP_API_URL: https://bhpa-backend-boston-heat-pump-accelerator-dbab1b.apps.shift.nerc.mghpcc.org |
There was a problem hiding this comment.
| REACT_APP_API_URL: https://bhpa-backend-boston-heat-pump-accelerator-dbab1b.apps.shift.nerc.mghpcc.org | |
| REACT_APP_API_URL: https://api.bostonhpa.org |
.github/workflows/deploy.yml
Outdated
| push: | ||
| # Edit to the branch(es) you want to build and deploy on each push. | ||
| branches: ['main'] |
There was a problem hiding this comment.
| push: | |
| # Edit to the branch(es) you want to build and deploy on each push. | |
| branches: ['main'] | |
| release: | |
| types: [published] |
|
@mattdelsordo Do you mind 👀 on the merge conflicts for the front end stuff here and then we can try taking this for a spin when MOC is ready? |
mattdelsordo
force-pushed
the
mattdelsordo/deploy-workflow
branch
from
cf55c47 to
36dbdff
Compare
|
does 🚀 mean I should merge this or |
Yes, merge it! We looked at this together tonight, but didn't want to merge it without you. |
I followed the example at https://github.com/nerc-project/simple-node-app and think this should "just work". I ran NERC's scripts to set the required secrets on the github project, but I'm not sure where to check whether that worked.
Resolves #483