diagnostic.py: Correct row and column number convention #39
Conversation
|
@jayvdb Could you please have a look why gitmate does not add labels automatically? |
|
Whoops, I ran coala on my laptop and found this commit doesn't pass GitCommitBear check. I'll fix it. |
li-boxuan
force-pushed
the
dev
branch
2 times, most recently
from
e3ae164 to
1f12f0a
Compare
| 'line': code['end']['line'] - 1, | ||
| 'character': code['end']['column'] | ||
| 'line': end_line, | ||
| 'character': end_char |
There was a problem hiding this comment.
Should we set the column to 0 or the whole line if the bear returns None?
There was a problem hiding this comment.
Oh yes, I should be careful about that.
According to LSP specification, if there is an issue with whole line x, the output format should be as follows:
{
start: { line: x, character: 0 }
end : { line: x + 1, character : 0 }
}There was a problem hiding this comment.
Cool, thus I think we should check if endline == startline.
li-boxuan
force-pushed
the
dev
branch
4 times, most recently
from
c7e9a6c to
1c094c9
Compare
|
ack 1c094c9 |
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
|
@gitmate-bot ff |
|
Hey @gaocegege, you do not have the access to perform the fastforward action with GitMate.io. Please ask a maintainer to give you access. |
gitmate-bot
added
process/approved
importance/medium
and removed
process/pending review
labels
fwiw, PRs can be based on top of another PR. |
Row and column number should be zero-based integer, not null Fixes coala#37
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
gitmate-bot
added
process/pending review
process/approved
and removed
process/approved
process/pending review
labels
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Row and column number should be zero-based integer, not null
Fixes #37