Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aws CLI auto-completions, use smaller kubectl package #924

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Feb 23, 2024

what

  • Fix aws auto-completion
  • Only install latest kubectl

why

  • The aws CLI is provided in 2 versions, v1 and v2, and which version is in use is managed by update-alternatives. However, each version of the CLI has a corresponding version of the aws_completer utility to perform auto-completion, but until now, Geodesic always used the v1 completer (a python script), even with the v2 CLI. This mostly worked, but it is not supported or correct.
  • Previously, we installed the kubectl package from packages.cloud.google.com, which is over 200 MB because it installs multiple versions of kubectl. We now install only the latest kubectl package from the Cloud Posse package repo, which is under 50 MB, to save space. Cloud Posse publishes packages for each minor version of kubectl (e.g. kubectl-1.29) so you can install the latest version compatible with your cluster if you do not want the current latest version.

references

This was brought to our attention by aws/aws-cli#8547 since upgrading to Python 3.12 in Geodesic v2.9.0.

@Nuru Nuru requested a review from a team as a code owner February 23, 2024 09:56
@github-actions github-actions bot added the shell label Feb 23, 2024
@Nuru Nuru merged commit 378a977 into master Feb 23, 2024
5 checks passed
@Nuru Nuru deleted the aws-autocomplete branch February 23, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant