Implement polling for instances deprovisioning #3667
+406
−196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Overall looks good, some polishing in tests is needed.
Also, linter is unhappy - pollProvisionOperation and pollDeprovisionOperation are quite similar.
I am not sure whether extracting the common code in an utility function would make the code look better, but you could give it a try. If not, you should suppress those warnings with a linter instruction comment, look here for an example
controllers/controllers/services/instances/managed/controller_test.go
Outdated
Show resolved
Hide resolved
controllers/controllers/services/instances/managed/controller_test.go
Outdated
Show resolved
Hide resolved
controllers/controllers/services/instances/managed/controller_test.go
Outdated
Show resolved
Hide resolved
zabanov-lab
force-pushed
the
issues/3586-do-not-delete-instance-when-unprovision-fails
branch
from
139dd8b to
151f9ab
Compare
There was a problem hiding this comment.
Left some minor comments. Also, one of the controllers tests is failing: https://github.com/cloudfoundry/korifi/actions/runs/12396243711/job/34603814936?pr=3667
controllers/controllers/services/instances/managed/controller.go
Outdated
Show resolved
Hide resolved
Added if staetement in OSBAPI CLient for unrecoverable errors and implemented polling to Deprovision last operation. Also, when deprovision fails the instance is not deleted, it sets the failed state to instance the last operation fixes cloudfoundry#3586 WIP Co-authored-by: Danail Branekov <[email protected]>
zabanov-lab
force-pushed
the
issues/3586-do-not-delete-instance-when-unprovision-fails
branch
from
1848a55 to
3ea52d9
Compare
danail-branekov
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added if staetement in OSBAPI CLient for unrecoverable errors and implemented polling to Deprovision last operation. Also, when deprovision fails the instance is not deleted, it sets the failed state to instance the last operation
Is there a related GitHub Issue?
#3586
Does this PR introduce a breaking change?
No