-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements the web platform standard reportError API #1979
Conversation
b55e4e2
to
9cc5ead
Compare
9cc5ead
to
7eb5029
Compare
If I call |
I think that still needs to be determined. The reporting is the same as the existing |
Yeah we should figure out before merging any change, since would be weird if this ended up showing as logs. @zebp and @maxwellpeterson may know and can point to internal tail worker code |
e138439
to
4468492
Compare
@irvinebroque ... ok, the PR has been updated to publish the reported error to the worker tracer as an exception. Unfortunately we can't actually have a test to verify it in workerd since workerd does not initialize the worker tracer at all. Manually verified in an internal test, however, that the reported error does, in fact, show up in the worker tracer as an exception, so I think we're good on that front. |
4468492
to
f34dbe9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supportive of landing this
f34dbe9
to
d8c8187
Compare
Refs: https://developer.mozilla.org/en-US/docs/Web/API/reportError
/cc @irvinebroque