Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new-window API to expose WebDriver's New Window endpoint #680

Merged
merged 4 commits into from
Oct 2, 2024

Conversation

dgr
Copy link
Contributor

@dgr dgr commented Oct 2, 2024

Closes #679

  • I have read CONTRIBUTING and the Etaoin Developer Guide.

  • This PR corresponds to an issue that the Etaoin maintainers have agreed to address.

  • This PR contains test(s) to protect against future regressions

  • I have updated CHANGELOG.adoc with a description of the addressed issue.

Copy link
Collaborator

@lread lread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Dave, looking good, I have a few comments.

.github/workflows/test.yml Outdated Show resolved Hide resolved
CHANGELOG.adoc Show resolved Hide resolved
test/etaoin/api_test.clj Show resolved Hide resolved
@lread lread merged commit 371a394 into clj-commons:master Oct 2, 2024
49 checks passed
@dgr dgr deleted the dgr-issue-679-new-window branch October 8, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement WebDriver New Window function
2 participants