morphological_chan_vese

[haesleinhuepf]

Hi @grahamross123 and @StRigaud ,

just to let you know: I made the morphological_chan_vese work. I'm adding a comment below highlighting the little tricky bit. I also renamed the function to be more similar to the scikit-image API.

If you have time, give it a try. I will otherwise merge and release in about a week.

Big thanks again for working on this!

closes #301
closes #229
closes #296

CC @jo-mueller

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.77489% with 76 lines in your changes missing coverage. Please review.

Project coverage is 92.99%. Comparing base (4bc2312) to head (05386b5).
Report is 226 commits behind head on master.

Files with missing lines	Patch %	Lines
pyclesperanto_prototype/_tier0/_cuda_execute.py	0.00%	26 Missing ⚠️
pyclesperanto_prototype/_tier0/_cuda_backend.py	0.00%	7 Missing ⚠️
pyclesperanto_prototype/_tier8/_deskew_x.py	14.28%	6 Missing ⚠️
pyclesperanto_prototype/_tier9/_imshow.py	0.00%	6 Missing ⚠️
tests/test_morphological_snakes.py	81.81%	6 Missing ⚠️
...ranto_prototype/_tier3/_morphological_chan_vese.py	92.42%	5 Missing ⚠️
pyclesperanto_prototype/_tier0/__init__.py	40.00%	3 Missing ⚠️
pyclesperanto_prototype/_tier0/_array_operators.py	90.00%	3 Missing ⚠️
...enerate_maximum_intensity_between_points_matrix.py	83.33%	2 Missing ⚠️
.../_generate_mean_intensity_between_points_matrix.py	83.33%	2 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
- Coverage   93.03%   92.99%   -0.04%     
==========================================
  Files         742      778      +36     
  Lines       13564    14440     +876     
==========================================
+ Hits        12619    13429     +810     
- Misses        945     1011      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[haesleinhuepf]

Hint: I had to initialize this image here with 0 because the create* functions only allocate memory. Further down, we compute temp_3 += .... which might be dangerous with a non-initialized image.

[grahamross123]

Thanks for finishing this @haesleinhuepf! It works as expected for me.