fixes core/5635 - Job params are ignored when job.execute is called

[MegaphoneJon]

Overview

Starting with #29598 (Civi 5.80.0), when calling Job.execute, the params for each scheduled job are ignored.

Before

See above

After

Pre-5.80 behavior is fixed

Technical Details

I think the array_merge() just had its array order reversed.

@mattwire does this match the original intent?

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[mattwire]

Yikes that sounds like a serious bug - I take it it's affecting all jobs?

Though looking at the previous code it appears to do the same thing with the array so not sure why anything would have changed?

[colemanw]

Tagging merge-ready per review on GitLab

[demeritcowboy]

Oops I missed this. I see it, and yes it fixes it. Thanks @MegaphoneJon

looking at the previous code it appears to do the same thing

It called storeValues() before.