Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RiverLea: 1.2.1-5.81 - fixes three regressions, one visual change #31620

Open
wants to merge 4 commits into
base: 5.81
Choose a base branch
from

Conversation

vingle
Copy link
Contributor

@vingle vingle commented Dec 18, 2024

Overview

This PR fixes three regressions:

  • RL hadn't yet integrated the rendered Radio Button fix
  • Selected Rows in SearchKit tables are illegible in Walbrook
  • Select2 accordions didn't work and showed expanded.
    In addition a visual change was made (still getting used to the multi-branch workflow). Strictly speaking this should go into master not the RC, but as we're still in the RL test period and it's a minor change hopefully it's ok.

Before: 1.2.0-5.81.beta

Select2 accordions:

image

Select in SK table:

image

Visual change - giant alert for 'no items' in table:

image

After: 1.2.1-5.81.beta

Select2 accordions:

image
image

Select in SK table:

image

Visual change - smaller alert for 'no items' in table
(NB - while there is a contrast ratio issue in the action buttons on the right - these buttons shouldn't be used anyway because this UX is to apply actions to multiple rows):

image

Technical Details

Copy link

civibot bot commented Dec 18, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.81 label Dec 18, 2024
@vingle vingle changed the title 5.81 RiverLea: 1.2.1-5.81 - fixes three regressions, one visual change Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant