RiverLea: 1.2.1-5.81 - fixes three regressions, one visual change #31620
+69
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes three regressions:
In addition a visual change was made (still getting used to the multi-branch workflow). Strictly speaking this should go into
master
not the RC, but as we're still in the RL test period and it's a minor change hopefully it's ok.Before: 1.2.0-5.81.beta
Select2 accordions:
Select in SK table:
Visual change - giant alert for 'no items' in table:
After: 1.2.1-5.81.beta
Select2 accordions:
Select in SK table:
Visual change - smaller alert for 'no items' in table
(NB - while there is a contrast ratio issue in the action buttons on the right - these buttons shouldn't be used anyway because this UX is to apply actions to multiple rows):
Technical Details