Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completions for additional gh pr subcommands #244

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

hexium310
Copy link
Collaborator

This PR adds completions for the following gh pr subcommands added to gh since #107.

  • checks
  • lock
  • unlock

@hexium310 hexium310 requested a review from chitoku-k February 21, 2024 18:09
@chitoku-k
Copy link
Owner

Please sort test cases by their subcommand name in alphabetical order.

@hexium310
Copy link
Collaborator Author

Do you want me to sort the existing test cases too?

@chitoku-k
Copy link
Owner

They are currently sorted in the order they are implemented. Just swap lock and unlock should be enough.

Copy link
Owner

@chitoku-k chitoku-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legit!

@chitoku-k chitoku-k merged commit a0593dd into master Feb 21, 2024
5 checks passed
@chitoku-k chitoku-k deleted the feat/gh-pr branch February 21, 2024 18:54
@chitoku-k chitoku-k added the command:gh Something about gh label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command:gh Something about gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants