Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply terraform fmt to all examples #303

Merged
merged 2 commits into from
Nov 26, 2024
Merged

chore: apply terraform fmt to all examples #303

merged 2 commits into from
Nov 26, 2024

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Nov 26, 2024

Currently, examples are not formatted with terraform fmt, which makes further tooling changes annoying.

This PR applies proper formatting to examples, and adds a new GitHub workflow that comments on PRs that change Terraform files with the result of terraform fmt and reports a failing check. I have tested the workflow by pushing commits with incorrect formatting (and then removing those commits again which is why they cannot be seen).

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

Copy link

github-actions bot commented Nov 26, 2024

Terraform Format and Style 🖌success

Format Output

@sorccu sorccu force-pushed the terraform-fmt branch 3 times, most recently from 2483816 to 6a45aa8 Compare November 26, 2024 13:03
@sorccu sorccu merged commit 33c63e9 into main Nov 26, 2024
7 checks passed
@sorccu sorccu deleted the terraform-fmt branch November 26, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant