Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch from Terraform Plugin SDK v2 to Terraform Plugin Framework #302

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

feat: switch from Terraform Plugin SDK v2 to Terraform Plugin Framework #302

wants to merge 21 commits into from

Conversation

sorccu
Copy link
Contributor

@sorccu sorccu commented Nov 19, 2024

This PR is a work in progress, incomplete, and may get reset multiple times. You can look but do not use.

Affected Components

  • Resources
  • Test
  • Docs
  • Tooling
  • Other

Pre-Requisites

  • Terraform code is formatted with terraform fmt
  • Go code is formatted with go fmt
  • plan & apply command of demo/main.tf file do not produce diffs

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu force-pushed the plugin-framework branch 7 times, most recently from 98f04a4 to 555fb98 Compare November 25, 2024 19:04
sorccu added 16 commits December 4, 2024 01:36
@sorccu
refactor: use a common ID attribute schema for all resource and data …
a36062e 
…sources
@sorccu
refactor: change heartbeat from legacy single-item Set to SingleNeste…
3df37b8 
…dAttribute
@sorccu
refactor: move sdk utilities into a separate sdkutil package
1c4aa86
@sorccu
refactor: start reorganizing files into a logical structure
36daf1d
@sorccu
refactor: use more accurate name for string set utility file
4fb539e
@sorccu
chore: remove files that have become unused
9c53f12
@sorccu
chore: go mod tidy
dc1869a
@sorccu
feat: move component registration to a separate package
f03271a 
This way future tests from child packages can refer to provider.New()
without introducing circular references. It also makes some potentially
interesting testing capabilities possible.
@sorccu
fix: ClientFromProviderData must allow nil ProviderData
b5a674c
@sorccu
feat: add first provider tests
44e087a 
Also added the possibility for the provider to ignore environment variables
if requested. This makes it possible to test scenarios where the various
configuration options are not set, even if environment variables have to be
set for the rest of the test suite.
@sorccu
feat: convert static_ips data source tests
e17ef61
@sorccu
chore: remove old provider test file
9f6dd5b
@sorccu
feat: convert snippet resource tests
1c19375
@sorccu
chore: reorder imports so that our own code is in its own section
7e915e3
@sorccu
feat: convert private_location resource tests
f01b286
@sorccu
feat: convert environment variable resource tests and fix behavior
c4c8f40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxigimenez maxigimenez Awaiting requested review from maxigimenez maxigimenez will be requested when the pull request is marked ready for review maxigimenez is a code owner

@pilimartinez pilimartinez Awaiting requested review from pilimartinez pilimartinez will be requested when the pull request is marked ready for review pilimartinez is a code owner

@Antoine-C Antoine-C Awaiting requested review from Antoine-C Antoine-C will be requested when the pull request is marked ready for review Antoine-C is a code owner

@shiini2 shiini2 Awaiting requested review from shiini2 shiini2 will be requested when the pull request is marked ready for review shiini2 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sorccu