Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorted providers by performance #17

Closed
wants to merge 1 commit into from

Conversation

kumar-kalyan
Copy link

Pull Request Template

Description

Sorted the cloud provider names by performances
issue:#10
PR's should be as atomic as possible 1 feature === 1 PR. 1 bugfix === 1 PR.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project. npm run lint passes with no errors.
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes. npm run test passes with no errors.

@vercel
Copy link

vercel bot commented Jan 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/checkly/jamstack-deploy/EL34uYFy8QUS1jR2nq4BJNNEyaBu
✅ Preview: https://jamstack-deploy-git-fork-kum9748ar-master-checkly.vercel.app

@ianaya89
Copy link
Contributor

ianaya89 commented Jan 4, 2022

Hi @kum9748ar, thanks for your contribution. I am not seeing here the providers are being sorted by performance, this is just alphabetical order.
The sort by performance needs an API interaction to get all providers metrics and use the TTFB to sort them in the client

@kumar-kalyan
Copy link
Author

@ianaya89 Thanks for your valuable feedback I will work on it :)

@ianaya89 ianaya89 closed this Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants