docs: document Prometheus tag/label parsing behaviour #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tnolet
reviewed
Dec 11, 2024
There was a problem hiding this comment.
@clample maybe explicitly also link to the prometheus spec? https://prometheus.io/docs/concepts/data_model/
Thanks Tim, I agree. I've updated this to link back to Prometheus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Pre-Requisites
npm run lint)Notes for the Reviewer
Please see for more context https://github.com/checkly/checkly-backend/pull/5911
Prometheus label keys should only contain a limited set of characters (docs):
This PR encourages users to only use valid characters in the label name.