Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add azure pipeline examples #1066

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add azure pipeline examples #1066

wants to merge 4 commits into from

Conversation

cjanslow
Copy link
Contributor

@cjanslow cjanslow commented Sep 6, 2024

Affected Components

  • Content & Marketing
  • Pricing
  • Test
  • Docs
  • Learn
  • Other

Pre-Requisites

  • Code is linted (npm run lint)

Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
checklyhq-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 10:33am

@cjanslow cjanslow marked this pull request as ready for review September 6, 2024 21:02
@cjanslow cjanslow requested a review from tnolet as a code owner September 6, 2024 21:02
@cjanslow cjanslow removed the request for review from tnolet September 6, 2024 21:02
@checklyalex
Copy link
Contributor

should the azure-pipelines.yml contain a environment var to be passed to the staging env? Do we need to pass anything to the feature branch to make Checkly aware of the env its running on or have I missed something?

Could we also prepare a short code snippet which shows the fetched vault secrets being used with npx checkly env add or update before running the tests?

@cjanslow
Copy link
Contributor Author

cjanslow commented Sep 12, 2024

@checklyalex

should the azure-pipelines.yml contain a environment var to be passed to the staging env?

I'm not sure what you mean by this. Can you please clarify?

Do we need to pass anything to the feature branch to make Checkly aware of the env its running on or have I missed something?

Do you mean for how it detects whether it runs E2EStaging or E2EProduction? This is detected by the condition set for each. For example, E2EStaging has this condition:

        condition: and(succeeded(), ne(variables['Build.SourceBranch'], 'refs/heads/main'))

This checks that the head of the SourceBranch is ne() --> not equal to main. For E2EProduction, it is the opposite using eq() --> equal. Let me know if that is not what you were asking.

Could we also prepare a short code snippet which shows the fetched vault secrets being used with npx checkly env add or update before running the tests?

I'm not sure I understand the use case of this. How do customers generally use key vault to pass secrets to Checkly, and are they generally happy to sync them in to Checkly as env vars? This almost feels like they'd want to fetch the secrets at run-time, rather than store them in Checkly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants