feat(alertchannels): Add webhook alertchannel type #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add webhook alertchannel type * Add general alertchannel configurations (send failure, degraded, recovery, ssl expiry) * Update docs, examples and tests
akosveres
commented
Nov 20, 2024
| | `opsgenie.apikey.fieldPath` | string; Key inside the secret or configmap | none | | ||
| | `webhook.name` | string; Name for the webhook | none | | ||
| | `webhook.url` | string; URL for the webhook | none | | ||
| | `webhook.webhookType` | string; TODO: can't determine what this is | none | |
There was a problem hiding this comment.
Could someone please tell me what this is used for? Couldn't determine based on the docs or the console UI.
There was a problem hiding this comment.
I looked into this and it seems like the value is not critical at all. It is mostly used as a bucket for monitoring and metrics purposes, and it may also be used in the frontend for display purposes. If the value is not set, or is set to an unsupported value, then it's effectively just the generic "WEBHOOK".
This is the list of valid values:
WEBHOOK_DISCORD
WEBHOOK_FIREHYDRANT
WEBHOOK_GITLAB_ALERT
WEBHOOK_SPIKESH
WEBHOOK_SPLUNK
WEBHOOK_MSTEAMS
WEBHOOK_TELEGRAM
WEBHOOK_CORALOGIX
WEBHOOK_ILERT
Note: It looks like you can provide an unsupported value as well, as I mentioned above. You will not get a validation error but it will behave the same as if no value was provided in the first place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #31