Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows): release workflow needs id-token write permission for npm provenance #1002

Conversation

sorccu
Copy link
Collaborator

@sorccu sorccu commented Dec 10, 2024

The 4.15.0 release workflow broke because now that we've updated to Node 18 with newer NPM, provenance is actually working (it tried to do it but could not). This permission is needed for provenance to work.

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

Resolves #[issue-number]

New Dependency Submission

@sorccu sorccu merged commit 75797f3 into main Dec 10, 2024
3 checks passed
@sorccu sorccu deleted the add-id-token-write-permission-to-release-workflow-for-npm-provenance branch December 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant