Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Add support for FIND_IN_SET operator #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuelPietro
Copy link

Description

This PR adds support for the FIND_IN_SET operator in the Medoo database framework. The implementation ensures compatibility with array values and updates parameter mapping to handle multiple values correctly.

Changes

  • Implemented FIND_IN_SET operator in the dataImplode method.
  • Added logic to handle array values for the FIND_IN_SET operator.
  • Updated parameter mapping to ensure unique keys for each value.

Impact

This enhancement allows users to use the FIND_IN_SET operator in their queries, providing more flexibility in handling comma-separated values within the database.

Testing

  • Added unit test to verify the functionality of the FIND_IN_SET operator.
  • Tested with various scenarios to ensure correct behavior and compatibility.

@catfan
Copy link
Owner

catfan commented Dec 4, 2024

Thank you for your contribution.

The FIND_IN_SET is only available for MySQL and MariaDB. It's not a general function.

I may design a new operator to support every database function call and can support this case also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants