Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cache to static pages in app router #18278

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 19, 2024

What does this PR do?

  • None of the pages we migrated so far in App Router are static pages, so this won't affect any pages in Production
  • But I am gonna start migrating static pages, so this logic is needed to have static pages properly cached (better perf)

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 7:28pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 7:28pm

@graphite-app graphite-app bot requested a review from a team December 19, 2024 19:20
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 19, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 19, 2024
@hbjORbj hbjORbj force-pushed the chore/add-cache-to-static-pages-in-app-router branch from f485626 to ec0e6c3 Compare December 19, 2024 19:23
Copy link

graphite-app bot commented Dec 19, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/19/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants