feat: virtual queues tab in insights #18260
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
dosubot
bot
added
insights
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/19/24)1 reviewer was added to this PR based on Keith Williams's automation. |
| export default function InsightsVirtualQueuesPage() { | ||
| const { t } = useLocale(); | ||
| const { data: routingForms, isLoading: isRoutingFormsLoading } = | ||
| trpc.viewer.insights.getUserRelevantTeamRoutingForms.useQuery(); |
There was a problem hiding this comment.
This only returns routing forms of teams the user is a member of + that have at least one route that redirects to a weighted round robin event type where the user is a host of
|
|
||
| for (const route of routes) { | ||
| if ("action" in route) { | ||
| const eventType = await prisma.eventType.findFirst({ |
There was a problem hiding this comment.
We should refactor this to get this data in bulk. We shouldn’t have prisma calls inside of nested loops.
There was a problem hiding this comment.
Hey @CarinaWolli i pushed 722d4c7 to use rawSQL instead of this nasty nested loop. I've tested it and it works as expected, if you have a better approach please just revert this commit!
| ) | ||
| ) | ||
| SELECT DISTINCT f.*, | ||
| jsonb_build_object( |
There was a problem hiding this comment.
We could have just not build a json object here and returned it as normal fields then loop over and map as we expect. But this was easier and saves us iterating over the data for the second time
| SELECT DISTINCT f.*, | ||
| jsonb_build_object( | ||
| 'parentId', t."parentId", | ||
| 'parent', CASE WHEN p.id IS NOT NULL THEN jsonb_build_object('slug', p.slug) ELSE NULL END, |
There was a problem hiding this comment.
Set parent.slug if we have a parent if not just set the parent field to null
| ) as "user" | ||
| FROM "App_RoutingForms_Form" f | ||
| INNER JOIN json_array_elements_recursive r ON f.id = r.id | ||
| INNER JOIN "EventType" e ON (r.route->>'action')::jsonb->>'eventTypeId' = e.id::text |
There was a problem hiding this comment.
Bonus of PGSQL we can easily query nested json without needing to do any JS magic
| WITH RECURSIVE json_array_elements_recursive AS ( | ||
| SELECT f.id, f."teamId", | ||
| jsonb_array_elements(f.routes::jsonb) as route | ||
| FROM "App_RoutingForms_Form" f | ||
| WHERE f."teamId" IN ( | ||
| SELECT "teamId" | ||
| FROM "Membership" | ||
| WHERE "userId" = ${userId} | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Recursive is always pretty scary but TLDR: We get all routing forms -> filter all forms to ones we are a member of -> expand routes into a single row so we can query it below using sql.
Example:
{
"id": 1,
"teamId": 123,
"routes": [
{ "action": { "eventTypeId": 456 } },
{ "action": { "eventTypeId": 789 } }
]
}Output:
id | teamId | route
1 | 123 | { "action": { "eventTypeId": 456 } }
1 | 123 | { "action": { "eventTypeId": 789 } }
Allows us to join later in the query on event type to get an output as follows
form.id | route.eventTypeId | eventType.id | eventType.schedulingType
form1 | 123 | 123 | roundRobin
form1 | 456 | 456 | collective
| }, | ||
| }, | ||
| }); | ||
| type FormWithRelations = App_RoutingForms_Form & { |
There was a problem hiding this comment.
This is the same response type we were getting from the prisma query
changed "virtual queue" to "Router Position" in nav
|
Seems like we're having API V2 failures. Any insights here? @ThyMinimalDev @hariombalhara |
What does this PR do?
This is a temporary solution to display virtual queues within insights for all members. In the future, we will automatically list the queues a user is part of. For now, we are reusing the implementation from Routing form testing. Instead of showing all the detailed routing data, we are only displaying the matching hosts along with the Round Robin data.
https://www.loom.com/share/23d6e794218f4388849f87c6506dbd75