Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove testing setup for app router migration #18255

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: remove testing setup for app router migration #18255

wants to merge 3 commits into from
+1 −223

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 18, 2024 •
edited
Loading

What does this PR do?

  • Remove testing setups for app router migration as these are no longer used
  • I want these removed now because they create merge conflicts as PRs for migration get merged
  • I modified the "Ignore build step" in Vercel staging to not look for vercel-app-router-deploy.sh anymore. Can you do the same for Vercel production? @zomars

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@graphite-app graphite-app bot requested a review from a team December 18, 2024 18:42
@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 18, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 18, 2024
@hbjORbj hbjORbj marked this pull request as draft December 18, 2024 18:43
@hbjORbj hbjORbj changed the title chore: remove testing setup for app router chore: remove testing setup for app router migration Dec 18, 2024
@hbjORbj hbjORbj marked this pull request as ready for review December 18, 2024 18:44
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 18, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/18/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

E2E results are ready!

@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 6:34pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 6:34pm

@hbjORbj
Copy link
Contributor Author

hbjORbj commented Dec 18, 2024

Drafted this. @zomars will approve/merge once he modifies the Vercel config in "Ignore Build Step"

@hbjORbj hbjORbj marked this pull request as draft December 18, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode