Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable overlay calendar by default for logged-in users #18191

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

retrogtx
Copy link
Contributor

Loom Video: https://www.loom.com/share/66ec51b1b9ba45c5b47f64881464e131?sid=b14ebee0-ba0b-4ff6-86a6-35c93f159d2a

What does this PR do?

Hope this helps.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Dec 15, 2024

@retrogtx is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team December 15, 2024 04:39
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 15, 2024
@graphite-app graphite-app bot requested a review from a team December 15, 2024 04:39
@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 15, 2024
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fixes #18146: enable overlay calendar by default for logged-in users". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added this to the v4.9 milestone Dec 15, 2024
Copy link

graphite-app bot commented Dec 15, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (12/15/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/15/24)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx retrogtx changed the title fixes #18146: enable overlay calendar by default for logged-in users fix: enable overlay calendar by default for logged-in users Dec 15, 2024
@retrogtx retrogtx changed the title fix: enable overlay calendar by default for logged-in users feat: enable overlay calendar by default for logged-in users Dec 15, 2024
Copy link

socket-security bot commented Dec 15, 2024

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@retrogtx
Copy link
Contributor Author

is this good enough? works fine

@Praashh @anikdhabal

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you uncommit yarn.lock file.

@retrogtx
Copy link
Contributor Author

can you uncommit yarn.lock file.

done!

@retrogtx retrogtx requested a review from Praashh December 16, 2024 11:28
Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tagging @anikdhabal for a final touch 🙏

Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! @sean-brydon can you review too?

@github-actions github-actions bot marked this pull request as draft December 18, 2024 12:43
@retrogtx retrogtx marked this pull request as ready for review December 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4882] turn "overlay your calendar" on by default if signed in
3 participants