-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable 'Overlay Calendar' enabled by default for signed in users #18188
base: main
Are you sure you want to change the base?
feat: enable 'Overlay Calendar' enabled by default for signed in users #18188
Conversation
@sanchitttt is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/14/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/14/24)1 label was added to this PR based on Keith Williams's automation. |
Changes Made: - 'Overlay Calendar' is enabled by default when the component mounts for signed in users - On every view which is toggled, 'Overlay Calendar' will be enabled by default for signed in users
Notes before mergingThe behavior which is present currently is that:
Clarification Needed
|
Changes Made: - 'Overlay Calendar' is enabled by default when the component mounts for signed in users in the web wrapper instead of the Booker Component
I would probably say this if im honest. Maybe we dont need to go as far as adding to a DB but deffo storing in local storage/cookies would be great for this. I don't think its blocking for this PR can it can be implemented in a follow up if you don't manage to get round to this before it's merged |
Changes Made: - Persist the user’s preference to keep it disabled, even after a view toggle.
What does this PR do?
Loom Video: https://www.loom.com/share/b67e6f4aa2ef4dcb9605cca4c28d74b9
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?