Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable 'Overlay Calendar' enabled by default for signed in users #18188

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sanchitttt
Copy link
Contributor

@sanchitttt sanchitttt commented Dec 14, 2024

What does this PR do?

Loom Video: https://www.loom.com/share/b67e6f4aa2ef4dcb9605cca4c28d74b9

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • For signed in user, simply see if "Overlay Calendar" is enabled by default
  • For un-signed user, simply see if "Overlay Calendar" is disabled by default

Copy link

vercel bot commented Dec 14, 2024

@sanchitttt is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 14, 2024
@graphite-app graphite-app bot requested a review from a team December 14, 2024 19:37
@github-actions github-actions bot added calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar Low priority Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 14, 2024
@dosubot dosubot bot added the booking-page area: booking page, public booking page, booker label Dec 14, 2024
@dosubot dosubot bot added this to the v4.9 milestone Dec 14, 2024
Copy link

graphite-app bot commented Dec 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/14/24)

1 label was added to this PR based on Keith Williams's automation.

Changes Made:
- 'Overlay Calendar' is enabled by default when the component mounts for signed in users
- On every view which is toggled, 'Overlay Calendar' will be enabled by default for signed in users
@sanchitttt
Copy link
Contributor Author

sanchitttt commented Dec 15, 2024

Notes before merging

The behavior which is present currently is that:

  1. 'Overlay Calendar' enabled on initial page load ✔️
  2. 'Overlay Calendar' enabled on every view which is toggled ✔️

Clarification Needed

  1. (Clarified below)
  • Should the 'Overlay Calendar' remain disabled if a user explicitly disables it?
    • Option 1: Re-enable by default on every view toggle (current behavior).
    • Option 2: Persist the user’s preference to keep it disabled, even after a view toggle.
  1. For what is the packages\platform\atoms\booker\BookerPlatformWrapper.tsx file used?
    • Are the same changes required there too?

Changes Made:
- 'Overlay Calendar' is enabled by default when the component mounts for signed in users in the web wrapper instead of the Booker Component
@sean-brydon
Copy link
Member

  • Option 2: Persist the user’s preference to keep it disabled, even after a view toggle.

I would probably say this if im honest. Maybe we dont need to go as far as adding to a DB but deffo storing in local storage/cookies would be great for this. I don't think its blocking for this PR can it can be implemented in a follow up if you don't manage to get round to this before it's merged

Changes Made:
- Persist the user’s preference to keep it disabled, even after a view toggle.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
booking-page area: booking page, public booking page, booker calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4882] turn "overlay your calendar" on by default if signed in
2 participants