Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: app router - /event-types pages #18181

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore: app router - /event-types pages #18181

wants to merge 7 commits into from

Conversation

hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Dec 14, 2024 •
edited
Loading

What does this PR do?

  • Fixes CAL-4892

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go to /event-types and /event-types/[type]

@graphite-app graphite-app bot requested a review from a team December 14, 2024 17:52
@vercel Vercel
Copy link

vercel bot commented Dec 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 7:08pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2024 7:08pm

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 14, 2024
@dosubot dosubot bot added the event-types area: event types, event-types label Dec 14, 2024
@hbjORbj hbjORbj marked this pull request as draft December 14, 2024 17:52
@keithwillcode keithwillcode added consumer core area: core, team members only labels Dec 14, 2024
@linear Linear
Copy link

linear bot commented Dec 14, 2024

CAL-4892 Remove Pages Router / Render App Router `/event-types`pages

@hbjORbj hbjORbj added high-risk Requires approval by Foundation team ready-for-e2e labels Dec 14, 2024
hbjORbj
hbjORbj commented Dec 14, 2024
View reviewed changes
packages/platform/atoms/event-types/wrappers/EventTypeWebWrapper.tsx
@@ -281,7 +240,7 @@ const EventTypeWeb = ({
} as const;

useHandleRouteChange({
watchTrigger: isAppDir ? pageRouter : pathname,
Copy link
Contributor Author

@hbjORbj hbjORbj Dec 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like we used an opposite conditional here

@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@hbjORbj hbjORbj changed the title chore: app router - event-types chore: app router - /event-types pages Dec 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024 •
edited
Loading

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThyMinimalDev ThyMinimalDev Awaiting requested review from ThyMinimalDev

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
consumer core area: core, team members only ❗️ .env changes contains changes to env variables event-types area: event types, event-types high-risk Requires approval by Foundation team ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @keithwillcode