Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no available users found while booking recurring event #18180

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sanchitttt
Copy link
Contributor

@sanchitttt sanchitttt commented Dec 14, 2024

  • No available users error was coming while booking recurring event since the 'first two slots' should be available logic was present while booking but not while showing availability

What does this PR do?

Loom Video: https://www.loom.com/share/26090f95cfed4818b167ca9ad0759582

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create a recurring event
  • Pick a date for which the next interval's slot does not exist [For example if you picked week recurring, the next week date]
  • The date slot for which the next interval's date slot does not exist, should not be selectable
  • Also , manually change the input occurences count to 1 for edge case, in the case of 1, all slots should appear and this logic will not apply

- No available users error was coming while booking recurring event since the 'first two slots' should be available logic was present while booking but not while showing availability
Copy link

vercel bot commented Dec 14, 2024

@sanchitttt is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 14, 2024
@graphite-app graphite-app bot requested a review from a team December 14, 2024 16:15
@github-actions github-actions bot added bookings area: bookings, availability, timezones, double booking High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. labels Dec 14, 2024
@sanchitttt
Copy link
Contributor Author

sanchitttt commented Dec 14, 2024

Notes Before Merging:

Usage of useNonEmptyScheduleDays()

These are the places where the useNonEmptyScheduleDays() function is being used.

image

  • I have not made any logic changes in these locations (Except the one highlighted).
  • Please confirm if the same changes (i.e., passing additionalParams) are required here as well.

Testing Coverage

  • I have tested the functionality for weekly, monthly, and yearly schedules, as these are the only options available when creating an event.
  • Let me know if additional support or testing is required for other options.

Copy link

graphite-app bot commented Dec 14, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/14/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/14/24)

1 label was added to this PR based on Keith Williams's automation.

@dosubot dosubot bot added this to the v4.9 milestone Dec 15, 2024
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution 🙏

Can we add a unit test to prevent future regressions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working community Created by Linear-GitHub Sync High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4864] Recurring events 'No available users found' error
2 participants