Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CAL-4864] Recurring events 'No available users found' error #18072

Open
CarinaWolli opened this issue Dec 9, 2024 · 5 comments · May be fixed by #18180
Open

[CAL-4864] Recurring events 'No available users found' error #18072

CarinaWolli opened this issue Dec 9, 2024 · 5 comments · May be fixed by #18180
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Milestone

Comments

@CarinaWolli
Copy link
Member

CarinaWolli commented Dec 9, 2024

For recurring events, we want to check the availability for the first two slots only. If other slots are not available the booking should still go through.

Currently, it throws an error when the second slot is not available:

Screenshot 2024-12-09 at 10.10.47 AM.png

We need to make sure to only load slots when the first two are available. We never want to throw this error.

From SyncLinear.com | CAL-4864

@CarinaWolli CarinaWolli added High priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 📉 regressing This used to work. Now it doesn't anymore. labels Dec 9, 2024
@CarinaWolli CarinaWolli changed the title [CAL-4864] Recurring event: No available users found error [CAL-4864] Recurring events 'No available users found' error Dec 9, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Dec 9, 2024
@sanchitttt
Copy link
Contributor

sanchitttt commented Dec 9, 2024

Hi @CarinaWolli,

Issue Replication Scenario for Recurring Events Booking

Scenario to Replicate the Bug in the Production Environment

  1. Availability Setup:

    • Set availability for the following dates:
      • December 11th: 10 AM - 11 AM
      • December 18th: 10 AM - 11 AM
      • December 25th: 10 AM - 11 AM
  2. Create Recurring Event:

    • Set up a recurring event that repeats every week for 6 occurrences, i.e., Dec 11, Dec 18, Dec 25, and so on.
  3. Booking Scenario:

    • User A books the slot on December 18th (1 occurrence).
    • User B books the slot on December 11th (2 occurrences).

Expected Behavior:

  • December 11th's slot should be successfully booked for User B.
  • December 18th's slot should be ignored in terms of checking availability, and the booking should still be processed for User A, as only the first two slots (December 11th and 18th) are being checked for availability.
  • The error should not be thrown when booking the second slot (December 18th) as long as the first slot is available.

Actual Behavior:

  • An error is thrown for User B when attempting to book for December 11th (first slot), since the second slot (December 18th) is unavailable.

Current Date in Example: December 10th


Clarification:

Is my interpretation correct?

Or should User B get both December 11th and December 25th instead of just December 11th?

@CarinaWolli
Copy link
Member Author

Expected Behavior:
December 11th's slot should be successfully booked for User B.
December 18th's slot should be ignored in terms of checking availability, and the booking should still be processed for User A, as only the first two slots (December 11th and 18th) are being checked for availability.
The error should not be thrown when booking the second slot (December 18th) as long as the first slot is available.

No. After December 18th is booked, then Dec 11th should not even be shown as available anymore if we are trying to book more occurrences. Currently, we check on booking confirmation the availability of the first two slots. We need to do the same for when loading slots, so also check for first two slots when loading slots

Actual Behavior:
An error is thrown for User B when attempting to book for December 11th (first slot), since the second slot (December 18th) is unavailable.

Correct

@sanchitttt
Copy link
Contributor

sanchitttt commented Dec 11, 2024

Expected Behavior:
December 11th's slot should be successfully booked for User B.
December 18th's slot should be ignored in terms of checking availability, and the booking should still be processed for User A, as only the first two slots (December 11th and 18th) are being checked for availability.
The error should not be thrown when booking the second slot (December 18th) as long as the first slot is available.

No. After December 18th is booked, then Dec 11th should not even be shown as available anymore if we are trying to book more occurrences. Currently, we check on booking confirmation the availability of the first two slots. We need to do the same for when loading slots, so also check for first two slots when loading slots

By that logic, the user shouldn't see any slots as available right? Since for my scenario if I only have Dec 11, 18 and 25 as availability. 18 is already booked. 11 cant be visible since it's next slot (ie 18) is already booked. And 25 cannot be booked since there is not availability after 25.

Can this statement be considered correct - "Every availability must have a consecutive availability for it to show for recurring events"

Also, if the user manually updates the occurences input box to 1, then will 11 and 25 be visible? [Edge case I think]

@rafarc21
Copy link

We are also struggling a lot with this issue. Would be extremely grateful to see it fixed. Happy to contribute if needed.

@CarinaWolli
Copy link
Member Author

CarinaWolli commented Dec 12, 2024

Also, if the user manually updates the occurences input box to 1, then will 11 and 25 be visible? [Edge case I think]

If occurrence is 1 it should show all slots and not check the availability for the second slot

@sanchitttt sanchitttt linked a pull request Dec 14, 2024 that will close this issue
3 tasks
@CarinaWolli CarinaWolli added this to the v4.9 milestone Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants