Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulley: Implement integer vector comparisons #9853

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

alexcrichton
Copy link
Member

More wast tests passing.

@alexcrichton alexcrichton requested review from a team as code owners December 18, 2024 18:41
@alexcrichton alexcrichton requested review from cfallin and dicej and removed request for a team December 18, 2024 18:41
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks right to me; I checked over most of this for copy-pastos but am additionally trusting the runtests as a backstop. Item of stray curiosity below but nothing to block on.

pulley/src/interp.rs Show resolved Hide resolved
@cfallin cfallin added this pull request to the merge queue Dec 18, 2024
Merged via the queue into bytecodealliance:main with commit 11e238e Dec 18, 2024
76 checks passed
@alexcrichton alexcrichton deleted the pulley-simd-compare branch December 18, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants