Use enum for directory/file permissions to make generated bindings easier to use #9598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Nov 14, 2024
…sier to use (bytecodealliance#9598) * Use enum for directory/file permissions to make generated bindings easier to use * Clarify names to emphasize these are or-able flags
alexcrichton
added a commit
that referenced
this pull request
Nov 15, 2024
* Expose wasmparser from environ for use in wasmtime-py (#9599) * Use enum for directory/file permissions to make generated bindings easier to use (#9598) * Use enum for directory/file permissions to make generated bindings easier to use * Clarify names to emphasize these are or-able flags --------- Co-authored-by: Jesse Rusak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of bytecodealliance/wasmtime-py#251, I want to use the File/Directory permission constants from the C API in Python. As defines, this is a bit tricky. Rather than hard-code them on the Python side, this PR makes them into an enum, and the existing C-to-Python logic is able to see & emit them. I have some work in progress which does this, see the resulting generated code and the nicer wrappers around them.