Update to latest wasmtime dev #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
2 tasks
atilag
pushed a commit
to atilag/wasmtime-py
that referenced
this pull request
Nov 19, 2024
atilag
pushed a commit
to atilag/wasmtime-py
that referenced
this pull request
Nov 19, 2024
alexcrichton
pushed a commit
that referenced
this pull request
Nov 25, 2024
* Wiring SharedMemory with it's corresponding bindings * Restoring _bindings.py as is being autogenerated out of the C-API interface in the wasmtime runtime repo * Removing SharedMemory read/write methods, as they are also not implemented in the Rust API for wasmtime. A SharedMemory is not associated to any Store, and the read/write methods from the linear memory seem to rely on the Store in order to properly operate. * Making SharedMemory inherit from the Manager type * Adding runtime typechecking to SharedMemory::_from_raw * After regenerating the bindings from wasmtime c-api (main/dev branch) and adjusting the shared memory arguments to match the new api, I found out that I needed to adjust other parts of the bindings that I guess have changed since the last release. In this commit, I only change the (shared) memory related ones, but I think I can adjust the rest of the c-api that has changed as well in the following commits. * Update to latest wasmtime dev (#257) * Retoring bindings from main branch as it was updated to latest changes in the C-APO from Wasmtime runtime repo * * Fixing Python types as suggested by mypy * Adding some unit tests for shared memory * Adding unit tests for shared memory --------- Co-authored-by: Jesse Rusak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #251
As discussed in there:
There is more we could do using the exposed enums (in existing bindings where we have numbers now) and exposing new APIs but thought we'd land this first.