Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .theme() #4995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Deprecate .theme() #4995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/src/main/java/com/bumptech/glide/RequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,6 +664,8 @@ private RequestBuilder<TranscodeType> maybeApplyOptionsResourceUri(
return applyResourceThemeAndSignature(requestBuilder);
}

// We should be able to remove the usage of theme in a future release
@SuppressWarnings("deprecation")
private RequestBuilder<TranscodeType> applyResourceThemeAndSignature(
RequestBuilder<TranscodeType> requestBuilder) {
return requestBuilder
Expand Down
6 changes: 6 additions & 0 deletions library/src/main/java/com/bumptech/glide/request/BaseRequestOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,13 @@ public T error(@DrawableRes int resourceId) {
*
* @param theme The theme to use when loading Drawables.
* @return this request builder.
*
* @deprecated The theme will be automatically applied from the {@link android.content.Context}
* associated with the {@link com.bumptech.glide.RequestManager} used to start this load. If you
* have a use case where calling this method is required for some reason, please file an issue at
* https://github.com/bumptech/glide/issues/new.
*/
@Deprecated
@NonNull
@CheckResult
public T theme(@Nullable Resources.Theme theme) {
Expand Down