-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Travis CI builds, update dependencies, and update list of as-yet unimplemented functions #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. should be a patch update
Minor note @ljharb |
0.1? Or 0.10? |
0.11/0.12 |
@ljharb
These are from the last build from 3 years ago. Perhaps trying to fix these would be worth your while |
gotcha, but they’ll pass now? If not, can we pin parse-asn1 so they do? |
If of course you have those issues fixed, then yes, this will just fine (see my last few posts here for what issues I'm talking about) |
Pretty much, if the parse-asn1 issue is fixed along with those connection refused issues, this will pass Travis CI |
Yep! 5.1.0 iirc is the last version that worked |
Any progress updates on this so far? Has the Saucelabs stuff been figured out yet? |
Looks like this fixes more than I first realized. |
do you how to implement the generateKeyPair |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomFill
and randomFillSync
are implemented :)
@@ -31,6 +31,15 @@ Here is the subset that is currently implemented: | |||
these features from node's `crypto` are still unimplemented. | |||
|
|||
* createCredentials | |||
* getCurves | |||
* randomFill | |||
* randomFillSync |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomFill
and randomFillSync
are implemented, we can remove this from the README
;['createCredentials', | ||
'getCurves', | ||
'randomFill', | ||
'randomFillSync', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
randomFill
and randomFillSync
are implemented, we can remove this from the error message array
this PR will return, eventually, just was cleaning out old repos, may merge this and #201 together into one PR |
Fixes #199
Fixes #196
Fixes #194
Fixes #192