WX-927 Task log streaming for GCP Batch #7540
Conversation
| .setDestination(Destination.PATH) | ||
| .setLogsPath(data.gcpBatchParameters.logfile.toString) | ||
| .build | ||
| ??? |
There was a problem hiding this comment.
IMHO TODO: turn Cloud Logging into a boolean option that defaults to true, while file-based task logging is always on.
There was a problem hiding this comment.
Also rather than being config-driven, we probably want to be able to drive Cloud Logging from workflow options so Terra users can click a checkbox to get this behavior iff they want it.
There was a problem hiding this comment.
made WX-1852 for workflow-option cloud logging
| @@ -16,6 +16,7 @@ object CallMetadataKeys { | |||
| val Failures = "failures" | |||
| val Stdout = "stdout" | |||
| val Stderr = "stderr" | |||
| val TaskLog = "task.log" | |||
There was a problem hiding this comment.
Personally I was never a huge fan of dynamic task log names, but others may be...
| @@ -498,6 +501,7 @@ trait StandardAsyncExecutionActor | |||
| |touch $stdoutRedirection $stderrRedirection | |||
| |tee $stdoutRedirection < "$$$out" & | |||
| |tee $stderrRedirection < "$$$err" >&2 & | |||
| |tail -q -f $stdoutRedirection $stderrRedirection > $taskLogRedirection & | |||
There was a problem hiding this comment.
NB this change was really meant only for the GCP Batch backend but here has been made in code that is common with the PAPI v2 backend
mcovarr
force-pushed
the
task_log_streaming
branch
from
704892e to
893df18
Compare
mcovarr
changed the title
mcovarr
changed the title
mcovarr
force-pushed
the
task_log_streaming
branch
from
5fed7d7 to
75e5d35
Compare
Description
Update: DO NOT MERGE, per 2024-09-27 sync meeting Google and Burwood are going to revisit a streaming file-based solution that includes localization, task logs, and delocalization.
Task log streaming for GCP Batch. Note this is not a perfect substitute for PAPI v2-style task logs as it does not include output from container setup, localization or delocalization.
Release Notes Confirmation
CHANGELOG.mdCHANGELOG.mdin this PRCHANGELOG.mdbecause it doesn't impact community usersTerra Release Notes