Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS ECR Remote Hashing #7444

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

sberss
Copy link

@sberss sberss commented Jun 3, 2024

Description

This change adds AWS ECR remote hashing support, which helps fix call caching for jobs using AWS ECR hosted containers. This change supports both private and public ECR registies.

There were a couple non-standard behaviours from ECR which have been mitigated in this PR:

  • Private ECR requires Basic authentication. The ability to override the authorization scheme for a particular registry was added.
  • ECR does not return a Docker-Content-Digest header, so a fallback to calculate the image digest from the response body has been added.
  • ECR supports images with no repository e.g. 123456790.dkr.ecr.eu-west-2.amazonaws.com/foo.

Release Notes Confirmation

CHANGELOG.md

  • I updated CHANGELOG.md in this PR
  • I assert that this change shouldn't be included in CHANGELOG.md because it doesn't impact community users

Terra Release Notes

  • I added a suggested release notes entry in this Jira ticket
  • I assert that this change doesn't need Jira release notes because it doesn't impact Terra users

@sberss sberss requested a review from a team as a code owner June 3, 2024 09:56
@sberss sberss force-pushed the aws-ecr-remote-hashing branch 2 times, most recently from fbf415b to 85d1030 Compare June 4, 2024 08:38
@sberss sberss force-pushed the aws-ecr-remote-hashing branch from 85d1030 to 3b90b0e Compare June 26, 2024 11:12
@sberss sberss force-pushed the aws-ecr-remote-hashing branch 2 times, most recently from f644ebe to a9fc6fa Compare June 26, 2024 11:13
@sberss sberss force-pushed the aws-ecr-remote-hashing branch from a9fc6fa to 45dea27 Compare June 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant