NETSCRIPT: Log script kill immediately and identify the guilty script.

[yichizhng]

This PR changes the timing of script death messages; the "Script killed" message is logged immediately by killWorkerScriptByPid, instead of waiting for the ScriptDeath exception on the next Netscript function call. The current behavior causes confusing log timings, e.g. if a script is killed during asleep.

Demo at https://yichizhng.github.io/bitburner-src/

[d0sboots]

FYI I'm holding off on PRs right now while we ensure 2.7 is stable, and also I think this might conflict with #1813 (which I'll merge first most likely)

[catloversg]

scriptKill also needs to be patched.

bitburner-src/src/NetscriptFunctions.ts

Line 1487 in 6e1848d

killWorkerScriptByPid(pid);

Optional: Change the messages of spawn ("About to exit...") and exit ("Exiting...") to "Script killed.".

• Before: Those messages are followed by "Script killed." due to the catch block in src\NetscriptWorker.ts.
• After: The catch block in src\NetscriptWorker.ts is changed, so there is no "Script killed." message.

Printing only "Exiting..." may be confusing for the player: "It's exiting, but when will the "exit" finish?".