Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Fix rounding issues due to ramOverride edge cases #1339

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

d0sboots
Copy link
Collaborator

@d0sboots d0sboots commented Jun 2, 2024

All RAM calculations must take place in units of hundredths-of-a-GB in order for there not to be issues.

Also adds slightly more verbose logging when the dynamic RAM check fails.
image

Fixes #1334

*All* RAM calculations must take place in units of hundredths-of-a-GB in
order for there not to be issues.

Also adds slightly more verbose logging when the dynamic RAM check
fails.
@d0sboots d0sboots merged commit 06d742a into bitburner-official:dev Jun 29, 2024
6 checks passed
@d0sboots d0sboots deleted the ram branch June 29, 2024 00:58
antoinedube pushed a commit to antoinedube/bitburner-source that referenced this pull request Aug 5, 2024
…official#1339)

*All* RAM calculations must take place in units of hundredths-of-a-GB in
order for there not to be issues.

Also adds slightly more verbose logging when the dynamic RAM check
fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server RAM calculation can get off due to rounding
1 participant