feat(lsp): workspaces #2607
Merged
feat(lsp): workspaces #2607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-Project
CodSpeed Performance ReportMerging #2607 will not alter performanceComparing Summary
|
ematipico
force-pushed
the
feat/support-workspace-lsp
branch
from
ec1b7b4 to
e3117ee
Compare
ematipico
force-pushed
the
feat/support-workspace-lsp
branch
from
85e015d to
91539b5
Compare
ematipico
force-pushed
the
feat/support-workspace-lsp
branch
from
b752dd0 to
9795a3d
Compare
ematipico
force-pushed
the
feat/support-workspace-lsp
branch
from
9795a3d to
991a23d
Compare
ematipico
force-pushed
the
feat/support-workspace-lsp
branch
from
6ab9c24 to
d4f57f8
Compare
anonrig
approved these changes
May 3, 2024
arendjr
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1573
This PR adds support for LSP workspaces to Biome LSP. Our internal implementation of
ServerWorkspacewill keep track of the different workspaces registered by the user.The Biome LSP now listens to
did_change_workspace_folders, which is triggered when a user changes (adds and/or removes) workspace folders.We will need to update our documentation, and explain that providing a
--config-pathwill remove the support of that via LSP. Essentially, users can't have both.Test Plan
I added a new test and tested manually