Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pulling localized surveys #331

Merged
merged 27 commits into from
Jun 2, 2021
Merged

Pulling localized surveys #331

merged 27 commits into from
Jun 2, 2021

Conversation

wasade
Copy link
Member

@wasade wasade commented May 26, 2021

This is not ready to merge yet

wasade
wasade commented May 28, 2021
View reviewed changes
microsetta_private_api/db/patches/0081.sql Outdated
@@ -0,0 +1,20 @@
-- spanish responses were not reflected in this table
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can merge this all into 0078

@wasade wasade changed the title WIP: pulling localized surveys Pulling localized surveys May 28, 2021
@wasade
Copy link
Member Author

wasade commented May 28, 2021

This fixes #301, #332, #334, #335 and positions for staging deploy.

@wasade wasade mentioned this pull request May 28, 2021
Closed
@wasade
Copy link
Member Author

wasade commented May 28, 2021

Fixes #328

dhakim87
dhakim87 requested changes Jun 1, 2021
View reviewed changes
Copy link
Collaborator

@dhakim87 dhakim87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong with merging changes 0080.sql and 0081.sql. We ended up with an empty script for 0080.sql and no corresponding change to migration_support.py as far as I can tell. Unclear to me why that set of changes was added into 0081.sql instead.

I suspect there's also a minor issue with height/weight parsing if the user enters gibberish when we then try to pass off to vioscreen.

microsetta_private_api/db/patches/0080.sql Show resolved Hide resolved
microsetta_private_api/db/patches/0081.sql Show resolved Hide resolved
microsetta_private_api/db/patches/0081.sql Show resolved Hide resolved
microsetta_private_api/repo/survey_template_repo.py Show resolved Hide resolved
@wasade
Copy link
Member Author

wasade commented Jun 1, 2021

I think something went wrong with merging changes 0080.sql and 0081.sql. We ended up with an empty script for 0080.sql and no corresponding change to migration_support.py as far as I can tell. Unclear to me why that set of changes was added into 0081.sql instead.

Ish. 0080.sql is already used in master which is creating problems

I suspect there's also a minor issue with height/weight parsing if the user enters gibberish when we then try to pass off to vioscreen.

Issue is on nulls but yes, there is a problem

wasade
wasade commented Jun 1, 2021
View reviewed changes
microsetta_private_api/repo/survey_template_repo.py Outdated
# TODO: the table *currently* uses the field "response" for an
# english response, but we should do something better w/
# i18n labels
localization.EN_US: "american",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...use survey_response.

@wasade wasade mentioned this pull request Jun 2, 2021
Closed
@dhakim87 dhakim87 merged commit 870a6f9 into biocore:i18n Jun 2, 2021
This was referenced Jun 4, 2021
Closed
Closed
@wasade wasade deleted the i18n branch December 13, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhakim87 dhakim87 dhakim87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wasade @dhakim87