-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to emscripten 1.35.0, ffmpeg 3.1.3 #55
base: master
Are you sure you want to change the base?
Conversation
Was running into the following error but it was solved by providing videoconverter.js/demo/worker-asm.js Line 25 in 42def8c
Why is the Anything left to move this forward to get a merge? I suppose the new async nature needs to be decided on. |
The newer Emscripten generates it. https://kripken.github.io/emscripten-site/docs/optimizing/Optimizing-Code.html#memory-initialization |
@dinedal I pulled this down and everything seems to work except png output. Can you advise what needs to change for png output to behave as expected? For reference, the following ffmpeg command fails at Output: Whereas, this command runs as expected: |
@bgrins Friendly ping on timeline to review/merge? |
This PR fixes both the all codecs and lgpl only build paths.
I tried to keep all emscripten only configure patches to either sed or .patch files, this way it makes it a little easier to upgrade dependencies later.
I had to make a change to the JS other changes for this to work; in this version of emscripten, using -O2 somehow breaks the synchronous API in ffmpeg-pre.js and ffmpeg-post.js. You must now use an asynchronous API during conversion; by specifying
Module['returnCallback'] = function(result) { ... }
seeworker-asm.js
for a full example. If you disable the -O2, the synchronous API from before works, I can only imagine that the new emscrpiten is culling the changes in optimization now.I also upgraded libvpx to 1.6 and x264 to x264-snapshot-20160910-2245