Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete LTAM code #48

Merged
merged 10 commits into from
Jun 1, 2016
Merged

Delete LTAM code #48

merged 10 commits into from
Jun 1, 2016

Conversation

rhansen
Copy link
Member

@rhansen rhansen commented May 16, 2016

LTAM has been superseded by SLURM so all of the LTAM code is now obsolete. It was never documented to users as being available, so quietly delete all of it.

This makes it easier to clean up the certificate verification code to fix issue #29.

@rhansen
Copy link
Member Author

rhansen commented May 16, 2016

@dseomn: I'd love to get a quick thumbs-up or -down from you if you're available. There's no need to review the changes unless you want to.

A possibly controversial change: I silently deleted the LTAM database flags without providing a check in bin/rpki/upgrade.in to see if the database contains any paracertificates. I may add a check before merging this in, but I don't know if it's worth spending the time.

@dseomn
Copy link
Member

dseomn commented May 18, 2016

@rhansen: Thumbs-up to removing LTAM code. I haven't reviewed this diff itself though. Adding a check to bin/rpki/upgrade.in and bailing if LTAM is in use should be relatively easy, if you get around to it. You could use a query something like select 1 from rpki_cert where ... limit 1 (replace ... with a flags test). If that query returns nothing, then LTAM is not in use, so proceed; otherwise it is, so bail.

rhansen added 9 commits May 31, 2016 17:08
These files are part of the implementation of LTAM
(draft-ietf-sidr-ltamgmt), which has been superseded by SLURM
(draft-ietf-sidr-slurm).
This option is part of the implementation of LTAM
(draft-ietf-sidr-ltamgmt), which has been superseded by SLURM
(draft-ietf-sidr-slurm).
These utilities are part of the implementation of LTAM
(draft-ietf-sidr-ltamgmt), which has been superseded by SLURM
(draft-ietf-sidr-slurm).
The rcli '-c' option and LTAM utilities were front-ends to a lot of
LTAM code that is no longer reachable.  Delete all of the
now-unreachable code.
useParacerts is initialized to 1, but it should no longer be possible
for it to still be 1 by the time it is checked (it should always be
set to 0 first) so delete it.
It is no longer possible for these flags to be set, and they should
have never been set given the user-facing utilities were never
documented as supporting LTAM.
rhansen added a commit to rhansen/rpstir that referenced this pull request Jun 1, 2016
@rhansen rhansen merged commit 0fa161f into master Jun 1, 2016
@rhansen rhansen deleted the delete-ltam branch June 1, 2016 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants