Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): 3510 - refonte algo affectation en js #4540

Merged
merged 8 commits into from
Dec 3, 2024
Merged

feat(api): 3510 - refonte algo affectation en js #4540

merged 8 commits into from
Dec 3, 2024

Conversation

achorein
Copy link
Collaborator

@achorein achorein commented Nov 15, 2024 •
edited
Loading

Description

Todo

Pré-requis :

  • Migration du code python en nodejs
  • Ajout de tests sur les différents sous éléments
  • Vérification iso fonctionnement python/node (depuis fichiers csv)
    • rapport excel
    • générer le pdf de statistiques
  • mettre en place tous les mappers
  • verifier le fonctionnement depuis la base mongo !

Nouvelles regles de gestion :

  • critères par centre : se rapprocher au maximum de l’équité Homme Femme, avoir un taux minimal (5%) de QPV par centre
  • un jeune part de son département de résidence, sauf pour les jeunes qui n’ont pas de PDR dans leur département, ils partent alors du département indiqué dans le SDR
  • il faut pouvoir sélectionner quels départements et quels niveau scolaires sont concernés par la simulation
  • vérifier contenu rapport de la simulation

Ticket / Issue

https://www.notion.so/jeveuxaider/Refonte-de-l-algorithme-d-affectation-HTS-Coeur-de-l-algo-11972a322d508071a5fec3aaa278ee32?pvs=23

Testing instructions

Réinitiliser une session pour refaire l'affectation :

db["youngs"].updateMany({ cohort: "Avril 2024 - C", statusPhase1: "DONE" }, { $set: { statusPhase1: "WAITING_AFFECTATION", ligneId: null, meetingPointsIds: [], cohesionCenterId: null}})

https://snufeatalgoaffectaticy3ynnaw-admin.functions.fnc.fr-par.scw.cloud/settings/operations?tab=simulations&cohort=Avril%202024%20-%20C

@achorein achorein added WIP Work In Progress R&R labels Nov 15, 2024
@achorein achorein self-assigned this Nov 15, 2024
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch 5 times, most recently from 0d6dc76 to ebe42d0 Compare November 19, 2024 13:26
@achorein achorein requested review from Johannbr and Eric013 November 19, 2024 13:27
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch 6 times, most recently from aa1c85c to f1acaac Compare November 20, 2024 08:39
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch 13 times, most recently from ed82e6b to 474a301 Compare November 26, 2024 13:59
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch 10 times, most recently from bd3e3a9 to 99fffea Compare November 30, 2024 15:23
Johannbr
Johannbr reviewed Dec 2, 2024
View reviewed changes
admin/src/scenes/settings/operations/simulations/ActionCell.tsx
simulation: Phase1Routes["GetSimulationsRoute"]["response"][0];
}

export default function ActionCell({ simulation }: ActionCellProps) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce que ce composant pourrait être réutilisable ? Si oui, dans snu-lib....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pour moi c'est vraiment propre à l'onglet "simutations" des "operations", ce n'est pas amené à être réutilisé.
si c'est le cas ça irait plus dans dans le DS.

.../src/scenes/settings/operations/simulations/somulationHts/SimulationHtsResultStartButton.tsx Outdated Show resolved Hide resolved
apiv2/package.json Outdated Show resolved Hide resolved
apiv2/src/admin/core/sejours/phase1/affectation/SimulationAffectationHTS.spec.ts Outdated Show resolved Hide resolved
apiv2/src/admin/core/sejours/phase1/centre/Centre.model.ts Outdated
sessionNames: string[];
sessionIds: string[];
listeAttente: string[];
statusSejour: string[];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

statutSejour

apiv2/src/shared/infra/AllExceptions.filter.ts Show resolved Hide resolved
apiv2/src/task/core/Task.gateway.ts Outdated Show resolved Hide resolved
apiv2/src/task/core/Task.model.ts Outdated Show resolved Hide resolved
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch from 99fffea to aab48b9 Compare December 2, 2024 16:10
@achorein achorein force-pushed the feat/algo-affectation-apiv2 branch from aab48b9 to 2442493 Compare December 3, 2024 08:26
@achorein achorein added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 608d5f9 Dec 3, 2024
4 of 9 checks passed
@achorein achorein deleted the feat/algo-affectation-apiv2 branch December 3, 2024 08:26
nicobret pushed a commit that referenced this pull request Dec 6, 2024
@achorein @nicobret
feat(api): 3510 - refonte algo affectation en js (#4540)
3742516
C2Chandelier pushed a commit that referenced this pull request Dec 9, 2024
@achorein
feat(api): 3510 - refonte algo affectation en js (#4540)
5534179
C2Chandelier pushed a commit that referenced this pull request Dec 10, 2024
@achorein
feat(api): 3510 - refonte algo affectation en js (#4540)
74e457a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippearnaud philippearnaud philippearnaud left review comments

@Johannbr Johannbr Johannbr approved these changes

@Eric013 Eric013 Awaiting requested review from Eric013

Assignees

@achorein achorein

Labels
R&R WIP Work In Progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achorein @philippearnaud @Johannbr