Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): 3142 - Fix inscription dashboard #4218

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicobret
Copy link
Collaborator

@nicobret nicobret commented Aug 22, 2024

Ticket : https://www.notion.so/jeveuxaider/BUG-informations-erron-es-affich-es-sur-le-tableau-de-bord-c5e874f5d29c433e9aa894eea787ed2a?pvs=4

Le dashboard répond à la question suivante : combien y a-t-il de volontaires validés qui :

  • soit sont scolarisés dans le département sélectionné
  • soit sont non scolarisés mais habitent dans le département sélectionné.

Alors que les listes de volontaires répondent à la question suivante :

  • combien y a-t-il de volontaires qui habitent dans le département sélectionné (qu’il y soient scolarisés ou non).

Dans cette PR : alignement des règles du dashboard Inscription pour se baser sur le département et la région de domiciliation uniquement.

@nicobret nicobret changed the title fix(api): 3142: Fix inscription dashboard fix(api): 3142 - Fix inscription dashboard Aug 22, 2024
@nicobret nicobret marked this pull request as ready for review August 22, 2024 14:19
Copy link

codeclimate bot commented Aug 22, 2024

Code Climate has analyzed commit 2c6eb9d and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 43.4% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants