Revert reading runtime params from GlobalStateAccessor #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit caddc0e.
glennmoy
force-pushed
the
gm/revert_gsa
branch
from
c2cd84e to
8e50b77
Compare
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 98.12% 97.42% -0.70%
==========================================
Files 12 12
Lines 639 660 +21
==========================================
+ Hits 627 643 +16
- Misses 12 17 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
I'll merge this if the cluster job successfully completes - I expect it to finish soon |
|
Even though our "large" MVP didn't succeed with this (disk space issue) it still lets us launch a job, so we will proceed with the merge. When we want to reimplement this we should refer back to #52 |
glennmoy
added
bug
2 tasks
kleinschmidt
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to rollback these changes until we've resolved #226
We can update the project version to 0.0.4 once this and #215 are merged as both are needed to run the MVP on the cluster