feature: added tooltip on icons #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taynambenichio
force-pushed
the
feature/icon-with-tooltip
branch
from
91841d3 to
983bdc6
Compare
taynambenichio
changed the title
DanielHe4rt
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Your PR looks good but it has a small problem: it was started from main branch and not develop. This is our fault and thankfully not imply in your pull request.
Besides that: the new implementation from Develop has the SettingsOption which should be followed. Fixing that it will be ready to merge.
BTW: thanks for the contribution <3
| @@ -61,8 +61,17 @@ const buildBadge = (occupation) => { | |||
| // SevenTV Stuff | |||
| badgeContainer.setAttributeNode(document.createAttribute("data-v-9f956e7d")); | |||
|
|
|||
| // Get the occupation object | |||
| const occupationObject = occupations.find((o) => o.apiValue === occupation); | |||
There was a problem hiding this comment.
We changed branches and now the occupation variable passed in the scope returns the SettingsOption object:
export type SettingsOption = {
name: string;
slug: string;
translation_key: string;
};
Comment on lines
+70
to
+74
| const title = | ||
| occupationObject.translationKey === "None" | ||
| ? "Twitch Better Profile" | ||
| : t(`occupation${occupationObject.translationKey}`); | ||
|
|
There was a problem hiding this comment.
ditto
Suggested change
| const title = | |
| occupationObject.translationKey === "None" | |
| ? "Twitch Better Profile" | |
| : t(`occupation${occupationObject.translationKey}`); | |
| const title = | |
| occupation.slug.toLowerCase() === "none" | |
| ? "Twitch Better Profile" | |
| : t(`occupation${occupation.translation_key}`); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tooltip on chat icons: