Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against php 8.2 and 8.3 #1471

Closed
wants to merge 3 commits into from
Closed

Test against php 8.2 and 8.3 #1471

wants to merge 3 commits into from

Conversation

sergiy-petrov
Copy link
Contributor

@sergiy-petrov sergiy-petrov commented Oct 4, 2023

Summary

Integration tests against 8.3 Unit tests against 8.2 and 8.3

Type of change

  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

laravel-ide-helper and others added 3 commits October 26, 2022 22:18
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mfn
Copy link
Collaborator

mfn commented Oct 4, 2023

@sergiy-petrov before merging, can you please clean up the commits (rebase/force-push), there's something off with them. Should only be one visible with the change in the yaml files?

@sergiy-petrov sergiy-petrov closed this by deleting the head repository Oct 5, 2023
@sergiy-petrov
Copy link
Contributor Author

@mfn I haven't figure out how to deal with odd commits, so I've created new PR - #1473

@mfn
Copy link
Collaborator

mfn commented Oct 5, 2023

No worries and thx, I merged the other one 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants