-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All contributors/add pinjasaur #3
Conversation
Co-authored-by: BlitzSprinter <[email protected]> Co-authored-by: Morgan Mastrangelo <[email protected]>
Reviewer's Guide by SourceryThis PR updates repository references throughout the codebase, changing the owner from 'JoshuaKGoldberg' to 'biltzsprinter'. The changes are implemented by updating URLs and references in various configuration and documentation files. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @morganm94 - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a typo in PULL_REQUEST_TEMPLATE.md where 'blob' is misspelled as 'lob' in the CONTRIBUTING.md URL
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -5,8 +5,8 @@ Otherwise we may not be able to review your PR. --> | |||
## PR Checklist | |||
|
|||
- [ ] Addresses an existing open issue: fixes #000 | |||
- [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Repository name is misspelled as 'blitzsprinter' instead of 'biltzsprinter'
@@ -5,8 +5,8 @@ Otherwise we may not be able to review your PR. --> | |||
## PR Checklist | |||
|
|||
- [ ] Addresses an existing open issue: fixes #000 | |||
- [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) | |||
- [ ] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/refined-saved-replies/blob/main/.github/CONTRIBUTING.md) were taken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (documentation): Broken link due to typo: 'replieslob' should be 'replies/blob'
<td align="center" valign="top" width="14.28%"><a href="https://twitter.com/Jolg42"><img src="https://avatars.githubusercontent.com/u/1328733?v=4?s=100" width="100px;" alt="Joël Galeran"/><br /><sub><b>Joël Galeran</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=Jolg42" title="Code">💻</a></td> | ||
<td align="center" valign="top" width="14.28%"><a href="https://www.keithcirkel.co.uk"><img src="https://avatars.githubusercontent.com/u/118266?v=4?s=100" width="100px;" alt="Keith Cirkel"/><br /><sub><b>Keith Cirkel</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/pulls?q=is%3Apr+reviewed-by%3Akeithamus" title="Reviewed Pull Requests">👀</a></td> | ||
<td align="center" valign="top" width="14.28%"><a href="https://luisestevez.me/"><img src="https://avatars.githubusercontent.com/u/128345934?v=4?s=100" width="100px;" alt="Luis Estevez"/><br /><sub><b>Luis Estevez</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/issues?q=author%3Aestevezluis" title="Bug reports">🐛</a> <a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=estevezluis" title="Code">💻</a></td> | ||
<td align="center" valign="top" width="14.28%"><a href="https://paulisaweso.me/"><img src="https://avatars.githubusercontent.com/u/6335792?v=4?s=100" width="100px;" alt="Paul Esch-Laurent"/><br /><sub><b>Paul Esch-Laurent</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=Pinjasaur" title="Documentation">📖</a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (documentation): Some contribution credits for Paul Esch-Laurent appear to have been removed
Previously listed contributions for Tools (🔧), Code (💻), and Maintenance (🚧) are no longer present. Was this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are ignoring the deployment issues for now, but approve the merged conflicts
PR Checklist
Summary by Sourcery
Enhancements: