Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All contributors/add pinjasaur #3

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

morganm94
Copy link
Collaborator

@morganm94 morganm94 commented Nov 4, 2024

PR Checklist

  • Updated home repo address, owner transition

Summary by Sourcery

Enhancements:

  • Update repository links and references from 'JoshuaKGoldberg' to 'biltzsprinter' across various files including README.md, CONTRIBUTING.md, package.json, and GitHub workflow files.

@morganm94 morganm94 added the documentation Improvements or additions to documentation label Nov 4, 2024
@morganm94 morganm94 self-assigned this Nov 4, 2024
Copy link

sourcery-ai bot commented Nov 4, 2024

Reviewer's Guide by Sourcery

This PR updates repository references throughout the codebase, changing the owner from 'JoshuaKGoldberg' to 'biltzsprinter'. The changes are implemented by updating URLs and references in various configuration and documentation files.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated repository owner references across documentation and configuration files
  • Changed repository owner from 'JoshuaKGoldberg' to 'biltzsprinter' in all GitHub URLs
  • Updated package.json repository and bugs URLs
  • Modified issue and PR template links
  • Updated contributor documentation links
  • Adjusted release workflow references
README.md
.github/CONTRIBUTING.md
package.json
.github/PULL_REQUEST_TEMPLATE.md
.github/ISSUE_TEMPLATE.md
.github/workflows/post-release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @morganm94 - I've reviewed your changes - here's some feedback:

Overall Comments:

  • There's a typo in PULL_REQUEST_TEMPLATE.md where 'blob' is misspelled as 'lob' in the CONTRIBUTING.md URL
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟡 Documentation: 3 issues found

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -5,8 +5,8 @@ Otherwise we may not be able to review your PR. -->
## PR Checklist

- [ ] Addresses an existing open issue: fixes #000
- [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Repository name is misspelled as 'blitzsprinter' instead of 'biltzsprinter'

@@ -5,8 +5,8 @@ Otherwise we may not be able to review your PR. -->
## PR Checklist

- [ ] Addresses an existing open issue: fixes #000
- [ ] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/refined-saved-replies/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/refined-saved-replies/blob/main/.github/CONTRIBUTING.md) were taken
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (documentation): Broken link due to typo: 'replieslob' should be 'replies/blob'

<td align="center" valign="top" width="14.28%"><a href="https://twitter.com/Jolg42"><img src="https://avatars.githubusercontent.com/u/1328733?v=4?s=100" width="100px;" alt="Joël Galeran"/><br /><sub><b>Joël Galeran</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=Jolg42" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://www.keithcirkel.co.uk"><img src="https://avatars.githubusercontent.com/u/118266?v=4?s=100" width="100px;" alt="Keith Cirkel"/><br /><sub><b>Keith Cirkel</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/pulls?q=is%3Apr+reviewed-by%3Akeithamus" title="Reviewed Pull Requests">👀</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://luisestevez.me/"><img src="https://avatars.githubusercontent.com/u/128345934?v=4?s=100" width="100px;" alt="Luis Estevez"/><br /><sub><b>Luis Estevez</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/issues?q=author%3Aestevezluis" title="Bug reports">🐛</a> <a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=estevezluis" title="Code">💻</a></td>
<td align="center" valign="top" width="14.28%"><a href="https://paulisaweso.me/"><img src="https://avatars.githubusercontent.com/u/6335792?v=4?s=100" width="100px;" alt="Paul Esch-Laurent"/><br /><sub><b>Paul Esch-Laurent</b></sub></a><br /><a href="https://github.com/biltzsprinter/refined-saved-replies/commits?author=Pinjasaur" title="Documentation">📖</a></td>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (documentation): Some contribution credits for Paul Esch-Laurent appear to have been removed

Previously listed contributions for Tools (🔧), Code (💻), and Maintenance (🚧) are no longer present. Was this intentional?

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

Copy link
Owner

@azurespheredev azurespheredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are ignoring the deployment issues for now, but approve the merged conflicts

@azurespheredev azurespheredev merged commit a56cea5 into main Nov 4, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants