Add a -bind-addr flag keeping default of 127.0.0.1 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, surely the default should be |
|
We also prefer to call it an 'allowlist' these days, FWIW. Although I note that's only in the commit comment not the code itself. |
Perhaps, but I think that's a different commit/PR - this keeps the default that's currently in main. |
|
It should at least be in the allowlist though? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a -bind-addr flag that is useful when serving on another address. The flag is optional and the default behaviour has not been changed.
I have also hard coded in an allowlist of possible addresses to ensure that this is not accidentally set to a public IP. The addresses are localhost and 169.254.169.254.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.