feat: handle virtual spaces when inserting code to cursor position #675
Conversation
ege0zcan
force-pushed
the
virtualSpaces
branch
2 times, most recently
from
e25f719 to
50cbdd1
Compare
ege0zcan
force-pushed
the
virtualSpaces
branch
from
50cbdd1 to
c45743b
Compare
| } | ||
|
|
||
| let textWithIndent = '' | ||
| params.code.split('\n').forEach((line, index) => { | ||
| if (index === 0) { | ||
| if (hasVirtualSpace) { | ||
| textWithIndent += indent |
There was a problem hiding this comment.
Similar to Line 233, if the first line is blank, it shouldn't receive indentations. (Can this also be added as a test case please?)
There was a problem hiding this comment.
I was under the impression that in the case of a virtual space we actually need this extra indent.
For a regular insertion (no virtual spaces) we don't add any indentation on the first line since the expectation is to insert the code block at the current cursor position and adding an indentation to the insertion would break the expectation
However, in the case of virtual spaces, the cursor might appear to the user at a certain position due to virtual spaces (e.g., 4 virtual spaces on a line, with the server receiving the cursor position as character 4). In this situation, the server must convert the virtual indentation into a real indentation when inserting the content into the file.
This is what the line in question achieves. To ensure the indentation is applied correctly, the server adjusts the cursor position to character 0 on line 222, so that the real spaces are inserted at the beginning of the line.
There was a problem hiding this comment.
Here is an arbitrary example for illustrative purposes. My comment above refers to line 81 in the sample image, but I have provided a complete representation of the desired outcome. It's a corner case where the first line is blank - generally this should be uncommon.
Desription
Adds the ability to handle virtual spaces to chat server
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.