Auto trigger revamp #4958
Draft
Auto trigger revamp #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Track SessionContext instead of InvocationContext 1. Since the shift from displaying one trigger at a time to displaying multiple triggers at a time, use SessionContext as the disposable for the session states. 2. Introduce the concept of "display session" which can show multiple triggers at a time and sessionContext is to hold states for that session. 3. ongoingRequests will be a map of <jobId, InvocationContext> where InvocationContext is the state of each trigger. 4. Managed these states globally by dynamically adding Trigger states into ongoingRequests and whenever the user made a decision(accept or reject), conclude decisions for all the ongoing triggers and clear ongoingRequest, so that a new display session can start later. * address comments
…ngs (#4914) * Replace old actions with new actions that have configurable key bindings 1. Accept (Tab) 2. Force Accept (Opt + Tab/Opt + Enter) 3. Navigate to Previous (Opt + [) 4. Navigate to Next (Opt + ]) * put sessionConext as project userdata and remove states of the actions * add popup keybinding hint and settings hyperlink * Addressing comments
* AutoTrigger logic tiny refactor 1. remove triggerOnIdle type code 2. address comments from previous PR * Update plugins/amazonq/codewhisperer/jetbrains-community/src/software/aws/toolkits/jetbrains/services/codewhisperer/service/CodeWhispererAutoTriggerService.kt Co-authored-by: Richard Li <[email protected]> --------- Co-authored-by: Richard Li <[email protected]>
* telemetry changes 1. UserTriggerDecision can now have Ignore and Unseen, (will later change to a new "MERGED" state indicating those other trigger results not accepted or rejected in the same display session) * address comments * address comments
…#4941) * Make CW popup showing on hover and IntelliSense popup non-conflicting 1. CW popup is hidden by default, on hovering over the suggestion text it will show. 2. On hovering over the suggestion, IntelliSense popup(if it's showing) will increase it's alpha to 0.8 3. Upon typing, if not hovering on the suggestion text, make CW hidden and IntelliSense not transparent. * add SessionContext as the dispoable for its subscriber in init * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.