Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on chunk size adjustment behavior #8828

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

tim-finnigan
Copy link
Contributor

Page: https://docs.aws.amazon.com/cli/latest/topic/s3-config.html#multipart-chunksize

Description of changes: Add note on chunk size adjustment behavior here in s3transfer.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@tim-finnigan tim-finnigan added documentation This is a problem with documentation. s3 labels Jul 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.08%. Comparing base (13b61bb) to head (8db6029).
Report is 1125 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #8828      +/-   ##
==========================================
- Coverage     0.08%   0.08%   -0.01%     
==========================================
  Files          208     210       +2     
  Lines        16554   16978     +424     
==========================================
  Hits            14      14              
- Misses       16540   16964     +424     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@elysahall elysahall self-requested a review December 10, 2024 18:02
@elysahall elysahall self-assigned this Dec 10, 2024
@elysahall elysahall added the pr:work-in-progress This PR is a draft and needs further work. label Dec 10, 2024
Copy link
Collaborator

@elysahall elysahall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sending for maintainer review.

@elysahall elysahall added pr:needs-review This PR needs a review from a Member. and removed pr:work-in-progress This PR is a draft and needs further work. labels Dec 10, 2024
@elysahall elysahall removed their assignment Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation. pr:needs-review This PR needs a review from a Member. s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants