Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amplify-libraries Flutter multibucket support documentation update #8115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ekjotmultani
Copy link
Member

Description of changes:

Amplify Flutter is adding multibucket support, so this PR updates the relevant API documentation to show how to use it

Related GitHub issue #, if available:

N/A

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.


## More `copy` options
You can also perform an `copy` operation to a specific bucket by providing the `CopyBuckets` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can also perform an `copy` operation to a specific bucket by providing the `CopyBuckets` option.
You can also perform a `copy` operation to a specific bucket by providing the `CopyBuckets` option.

@@ -1116,6 +1123,7 @@ final operation = Amplify.Storage.downloadFile(
getProperties: true,
useAccelerateEndpoint: true,
),
bucket: StorageBucket.fromOutputs('secondBucket'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: This is optional right? Would a more explicit example and/or description be beneficial?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will coalesce them into their own section about multi bucket like the other apis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants